Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CfnInsightRule and TagManager: Duplicate tag key/value pair leads to INVALID_TAG issue #30056

Closed
neilzhao-aws opened this issue May 3, 2024 · 3 comments
Labels
@aws-cdk/aws-cloudtrail Related to AWS CloudTrail bug This issue is a bug. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/medium Medium work item – several days of effort p2 response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.

Comments

@neilzhao-aws
Copy link

Describe the bug

Following the thread of #20103 but with more evidence.
Digging into CloudTrail, the INVALID_TAG from CfnInsightRules are caused by duplicate key/value pairs.
One of the Tags KeyValue pair is duplicated in the PutInsightRule CloudTrail event.
The CDK changeset shows the key/value pair isn't duplicated

Expected Behavior

CfnInsightRule generated PutInsightRule should not duplicate tags.

Current Behavior

CfnInsightRule generated PutInsightRule should one duplicate tags.

Reproduction Steps

create multiple tags on the stack level.

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.132.0

Framework Version

No response

Node.js Version

18.19.1

OS

Linux

Language

TypeScript

Language Version

4.9.5

Other information

I don't think the bug is related to CDk. the cloudformation output is correct.
However, the PutInsightRule action taken by the cdk has an extra duplicated tag, leading to the issue.

@neilzhao-aws neilzhao-aws added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels May 3, 2024
@github-actions github-actions bot added the @aws-cdk/aws-cloudtrail Related to AWS CloudTrail label May 3, 2024
@pahud
Copy link
Contributor

pahud commented May 6, 2024

Reproduction Steps
create multiple tags on the stack level.

Can you share the minimal code snippets that reproduces this bug?

@pahud pahud added p2 response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels May 6, 2024
Copy link

github-actions bot commented May 8, 2024

This issue has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added closing-soon This issue will automatically close in 4 days unless further comments are made. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels May 8, 2024
@aws-cdk-automation
Copy link
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
@aws-cdk/aws-cloudtrail Related to AWS CloudTrail bug This issue is a bug. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/medium Medium work item – several days of effort p2 response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.
Projects
None yet
Development

No branches or pull requests

3 participants