Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

command parameter for NetworkLoadBalancedTaskImageOptions #30760

Open
2 tasks
Smotrov opened this issue Jul 5, 2024 · 2 comments · May be fixed by #30775
Open
2 tasks

command parameter for NetworkLoadBalancedTaskImageOptions #30760

Smotrov opened this issue Jul 5, 2024 · 2 comments · May be fixed by #30775
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p3

Comments

@Smotrov
Copy link

Smotrov commented Jul 5, 2024 •
edited
Loading

Describe the feature

Despite the fact that ApplicationLoadBalancedTaskImageOptions has command property, NetworkLoadBalancedTaskImageOptions doesn't.

Use Case

Docker has multiple apps inside. I need to tell to ECS which one to start.

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.147.3 (build 32f0fdb)

Environment details (OS name and version, etc.)

MacOS
@Smotrov Smotrov added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jul 5, 2024
@github-actions github-actions bot added the @aws-cdk/aws-ecs Related to Amazon Elastic Container label Jul 5, 2024
@khushail khushail added investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-triage This issue or PR still needs to be triaged. labels Jul 5, 2024
@nmussy
Copy link
Contributor

nmussy commented Jul 7, 2024

I noticed a couple of other missing props both for NetworkLoadBalancedEc2Service and NetworkLoadBalancedFargateService, I'll open a PR for them

This was referenced Jul 7, 2024
Closed
Open
This was referenced Jul 8, 2024
Closed
Closed
@khushail
Copy link
Contributor

khushail commented Jul 8, 2024

Thanks @Smotrov for requesting the feature and submission of PR!

@khushail khushail added p3 effort/small Small work item – less than a day of effort and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Jul 8, 2024
@github-actions github-actions bot mentioned this issue Aug 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p3
Projects
None yet
Milestone
No milestone
3 participants
@nmussy @Smotrov @khushail