Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cdk diff doesn't report any policy created within a role in a included cfn template #8683

Closed
gmiretti opened this issue Jun 22, 2020 · 3 comments
Closed

cdk diff doesn't report any policy created within a role in a included cfn template #8683

gmiretti opened this issue Jun 22, 2020 · 3 comments
Assignees
@skinny85
Labels
bug This issue is a bug. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. p1 response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.

Comments

@gmiretti
Copy link

cdk diff should report any policy to be created by a deploy.
This doesn't happen when policy are created in a included template

Reproduction Steps

Empty python project with stack only doing core.CfnInclude() of template
https://s3.amazonaws.com/aws-transfer-resources/custom-idp-templates/aws-transfer-custom-idp-secrets-manager-apig.template.yml
from https://aws.amazon.com/blogs/storage/enable-password-authentication-for-aws-transfer-for-sftp-using-aws-secrets-manager/

Error Log

cdk diff doesn't report any policy created with a role when template defines 3 roles with their respective policy

Environment

  • CLI Version : cdk 1.45
  • Framework Version: aws-cdk.core==1.45.0
  • Node.js Version: v12.18.0
  • OS : Ubuntu 18.04.4
  • Language (Version): Python 3.6.9

This is 🐛 Bug Report
@gmiretti gmiretti added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Jun 22, 2020
@gmiretti gmiretti mentioned this issue Jun 22, 2020
Closed
@skinny85 skinny85 self-assigned this Jun 22, 2020
@skinny85 skinny85 added the p1 label Jun 29, 2020
@skinny85
Copy link
Contributor

skinny85 commented Sep 5, 2020

Hey @gmiretti ,

when you say cdk diff - do you mean the IAM prompt that we show for permission changes?

Thanks,
Adam

@skinny85 skinny85 added the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Sep 5, 2020
@SomayaB SomayaB removed the needs-triage This issue or PR still needs to be triaged. label Sep 8, 2020
@github-actions
Copy link

This issue has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added closing-soon This issue will automatically close in 4 days unless further comments are made. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Sep 12, 2020
@gmiretti
Copy link
Author

gmiretti commented Sep 16, 2020 •
edited
Loading

when you say cdk diff - do you mean the IAM prompt that we show for permission changes?

Yes, @skinny85 , sorry for the late reply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skinny85 skinny85

Labels
bug This issue is a bug. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. p1 response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@skinny85 @gmiretti @SomayaB