-
Notifications
You must be signed in to change notification settings - Fork 550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDK request are not compressed, add header Accept-Encoding: gzip, deflate in all http requests #41
Comments
Understood. Gzip compression had been turned on since v2.2.0 release. However we had to turned it off in v2.2.1 because it caused crc32 checksum exception in DynamoDB. lscheinkman proposed a promising solution #40 and we will test it before taking it. Please keep an eye on the next release. |
Sorry I opened another bug I didn't see that one. Yeah I was just digging it out and find out your comment about disabling for the CRC issue. I went forward and edited the SDK code by re-enabling http compression and disabling the CRC check (actually just commented out the exception if missmatch) I tested my app out and it was the result in speed was amazing compared to what I had before. Of course disabling CRC check is not a good thing and yes, I think that the right solution should be to manually handle the compression and perform the CRC check after decompressing the response. This is a show stopper for us tough, do you have any ETA for when the release with gzip compression will be enabled? |
We can't make you a promise, but we are aiming at a release in a week or so. |
The latest release v2.2.2 enables HTTP compression. It also correctly handles crc32 checksum with DynamoDB. See http://aws.amazon.com/releasenotes/4067314458888112 for details. |
I just started noticing that I am getting a lot of crc32 errors starting in 2.3.1. com.amazonaws.AmazonClientException: Unable to execute HTTP request: Client calculated crc32 checksum didn't match that calculated by server side |
gradle Tested on different devices with different Android-Versions. |
catch an exceptioncom.amazonaws.AmazonClientException: Unable to execute HTTP request: Client calculated crc32 checksum didn't match that calculated by server side I got a same exception. Is there something i can do about it.Going back to an older sdk version? |
The SDK does not set Accept-Encoding: gzip, deflate when performing request, the result is that when there is lot of text the SDK:
The text was updated successfully, but these errors were encountered: