Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add common types to Mimetypes.java #83

Closed
paleozogt opened this issue Dec 23, 2015 · 6 comments
Closed

add common types to Mimetypes.java #83

paleozogt opened this issue Dec 23, 2015 · 6 comments
Labels
feature-request Request a new feature

Comments

@paleozogt
Copy link

Could we get some common mime-types added to Mimetypes.java? For example, application/json and text/yaml would be very useful.

@fosterzhang fosterzhang added the feature-request Request a new feature label Dec 23, 2015
@fosterzhang
Copy link
Contributor

Probably a better approach is to provide a method to let user register new mime types. What do you say?

@paleozogt
Copy link
Author

That would also work. At the moment you have to stand on your head to do it by feeding it an InputStream. Also, it feels weird manipulating an "internal" class.

@fosterzhang
Copy link
Contributor

@paleozogt That's true :). I don't mind moving it out of internal if there is a valid reason. The method using InputStream isn't very helpful. I'll add a friendly method shortly. Stay tuned.

@paleozogt
Copy link
Author

Sounds great. Thanks!

@fosterzhang
Copy link
Contributor

This has been added to v2.2.10 release. Please check out the release notes.

@paleozogt
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request a new feature
Projects
None yet
Development

No branches or pull requests

2 participants