Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsisent naming of No-op behavior and types in SDK. #878

Closed
jasdel opened this issue Nov 3, 2020 · 3 comments
Closed

Inconsisent naming of No-op behavior and types in SDK. #878

jasdel opened this issue Nov 3, 2020 · 3 comments
Labels
automation-exempt bug This issue is a bug.
Milestone
v1.0 Release Cand...

Comments

@jasdel
Copy link
Contributor

jasdel commented Nov 3, 2020

The SDK uses different patterns for naming no-op behavior, e.g. smithyhttp.NopClient vs logging.Noop. These SDK should use a single standard naming for consistency.
@jasdel jasdel added the bug This issue is a bug. label Nov 3, 2020
@jasdel jasdel mentioned this issue Nov 3, 2020
Merged
@skmcgrail
Copy link
Member

This also includes NoOpRetryer, TestingUsingNoOpSleep.

@jasdel jasdel added this to the v1.0 Release Candidate milestone Nov 11, 2020
@jasdel
Copy link
Contributor Author

jasdel commented Dec 17, 2020

Fixed in #987

@jasdel jasdel closed this as completed Dec 17, 2020
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@dependabot dependabot bot mentioned this issue Mar 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
automation-exempt bug This issue is a bug.
Projects
None yet
Milestone
v1.0 Release Candidate
Development

Successfully merging a pull request may close this issue.

Bump github.com/aws/aws-sdk-go-v2 from 0.24.0 to 0.31.0 YashdalfTheGray/federator
2 participants
@skmcgrail @jasdel