fix(uint32ArrayFrom): increment index & polyfill for Uint32Array #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottarc
previously approved these changes
Nov 29, 2021
| @@ -3,11 +3,12 @@ | |||
|
|
|||
| // IE 11 does not support Array.from, so we do it manually | |||
| export function uint32ArrayFrom(a_lookUpTable: Array<number>): Uint32Array { | |||
| if (!Array.from) { | |||
| if (!Uint32Array.from) { | |||
There was a problem hiding this comment.
Will we need this for other types (Uint8Array.from) in the future?
| const return_array = new Uint32Array(a_lookUpTable.length) | ||
| let a_index = 0 | ||
| while (a_index < a_lookUpTable.length) { | ||
| return_array[a_index] = a_lookUpTable[a_index] | ||
| a_index += 1 |
There was a problem hiding this comment.
👍 this looks like the correct fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #269
Description of changes:
PR is not yet tested on IE 11
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.