The types in the ThirdParty namespace are externally visible

[AnthonyMastrean]

Describe the bug

The types in the ThirdParty namespace are externally visible.

Regression Issue

• Select this option if this issue appears to be a regression.

Expected Behavior

I should not see these types exposed in some utility namespace.

Current Behavior

I see these types exposed in some utility namespace.

Reproduction Steps

Install the package, use a type that can be resolved from multiple packages/namespaces (such as JsonException) and note that ThirdParty shows up in the list of possible imports.

Possible Solution

Mark these types internal.

Additional Information/Context

No response

AWS .NET SDK and/or Package version used

AWSSDK.Core 3.7.400.35

Targeted .NET Platform

.NET 8

Operating System and version

All platforms

[ashishdhingra]

@AnthonyMastrean Good morning. Thanks for opening the issue. While it makes sense to mark them as internal, however, doing so in current version of SDK would be a breaking change for existing customers that might be using these public members. This needs review with the team if these could be marked them as internal in new major version v4 in development.

Thanks,
Ashish

[normj]

I understand your concern but it is something we can not do, at least without more effort then we can spend on it. There are cases where the services packages like AWSSDK.EC2 need to access to the code in ThirdParty. We can't rely on the InternalsVisibleToAttribute attribute because sometimes the service package is being used with a version AWSSDK.Core that didn't exist when the service package was created.

[github-actions]

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.