From 05891919caf18bef86bbcc43175b57d242736f6d Mon Sep 17 00:00:00 2001
From: Paulo Morgado <470455+paulomorgado@users.noreply.github.com>
Date: Tue, 6 Aug 2024 18:33:14 +0100
Subject: [PATCH] Optimize memory usage and improve code readability

Added System.Buffers to StringUtils.cs.
Refactored FromMemoryStream to use MemoryStream.TryGetBuffer and ArrayPool<byte> for efficient memory handling.
Modified FromString method signature without changing implementation.
Made minor formatting changes in FromValueTypeList and headerListEntry processing logic to enhance readability.
---
 .../Internal/Util/StringUtils.cs              | 27 +++++++++++++++----
 1 file changed, 22 insertions(+), 5 deletions(-)

diff --git a/sdk/src/Core/Amazon.Runtime/Internal/Util/StringUtils.cs b/sdk/src/Core/Amazon.Runtime/Internal/Util/StringUtils.cs
index 37ea49c9ebe5..d635e96ae8b9 100644
--- a/sdk/src/Core/Amazon.Runtime/Internal/Util/StringUtils.cs
+++ b/sdk/src/Core/Amazon.Runtime/Internal/Util/StringUtils.cs
@@ -21,6 +21,7 @@
 using Amazon.Util;
 using System.Linq;
 using System.Diagnostics.CodeAnalysis;
+using System.Buffers;
 
 namespace Amazon.Runtime.Internal.Util
 {
@@ -32,7 +33,7 @@ public static class StringUtils
         private static readonly Encoding UTF_8 = Encoding.UTF8;
         private static readonly char[] rfc7230HeaderFieldValueDelimeters = "\"(),/:;<=>?@[\\]{}".ToCharArray();
 
-        public static string FromString(String value) 
+        public static string FromString(String value)
         {
             return value;
         }
@@ -49,14 +50,30 @@ public static string FromString(ConstantClass value)
 
         public static string FromMemoryStream(MemoryStream value)
         {
-            return Convert.ToBase64String(value.ToArray());
+            if (value.TryGetBuffer(out var buffer))
+            {
+                return Convert.ToBase64String(buffer.Array, buffer.Offset, buffer.Count);
+            }
+            else
+            {
+                var array = ArrayPool<byte>.Shared.Rent((int)value.Length);
+                try
+                {
+                    value.Read(array, 0, (int)value.Length);
+                    return Convert.ToBase64String(array, 0, (int)value.Length);
+                }
+                finally
+                {
+                    ArrayPool<byte>.Shared.Return(array);
+                }
+            }
         }
 
         public static string FromInt(int value)
         {
             return value.ToString(CultureInfo.InvariantCulture);
         }
-        
+
         public static string FromInt(int? value)
         {
             if (!value.HasValue)
@@ -348,7 +365,7 @@ public static string FromValueTypeList<T>(IEnumerable<T> values) where T : struc
         /// <param name="values">List of T</param>
         /// <returns>Header value representing the list of T</returns>
         [SuppressMessage("Microsoft.Globalization", "CA1308", Justification = "Value is not surfaced to user. Booleans have been lowercased by SDK precedent.")]
-        public static string FromValueTypeList<T>(List<T> values)  where T : struct
+        public static string FromValueTypeList<T>(List<T> values) where T : struct
         {
             // ToString() on boolean types automatically Pascal Cases. Xml-based protocols
             // are case sensitive and accept "true" and "false" as the valid set of booleans.
@@ -404,7 +421,7 @@ private static string EscapeHeaderListEntry(string headerListEntry)
             if (headerListEntry.IndexOfAny(rfc7230HeaderFieldValueDelimeters) != -1)
             {
                 return $"\"{headerListEntry.Replace("\"", "\\\"")}\"";
-            }            
+            }
 
             return headerListEntry;
         }