Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide option to skip commit in postgresql.to_sql to allow usage of transactions #2790

Closed
Salatich opened this issue Apr 25, 2024 · 1 comment · Fixed by #2795
Closed

Provide option to skip commit in postgresql.to_sql to allow usage of transactions #2790

Salatich opened this issue Apr 25, 2024 · 1 comment · Fixed by #2795
Labels
enhancement New feature or request

Comments

@Salatich
Copy link

Is your idea related to a problem? Please describe.
Currently, if there are no exceptions when calling awswrangler.postgresql.to_sql then commit is automatically done:

It makes it impossible to use awswrangler.postgresql.to_sql as a part of a transaction which e.g. writes multiple tables, because if one of the transaction steps fails, you cannot rollback all the changes, just the last one.

Describe the solution you'd like
To add extra parameter for awswrangler.postgresql.to_sql as it was done here, but for redshift:
#705

@jaidisido
Copy link
Contributor

Thanks, to be addressed in #2795

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants