Skip to content
This repository has been archived by the owner on Nov 5, 2024. It is now read-only.

Very partial list of errors defined in smithy S3 model #376

Closed
kellertk opened this issue Oct 19, 2022 · 6 comments
Closed

Very partial list of errors defined in smithy S3 model #376

kellertk opened this issue Oct 19, 2022 · 6 comments
Assignees
Labels
s3 service-api This issue pertains to the AWS API

Comments

@kellertk
Copy link
Contributor

This issue is to continue the issues in smithy-lang/smithy#1147 (it's currently not possible to directly transfer issues between GitHub orgs). The original issue text is below:


Hi

For context:

When I look at the S3 smithy model, I find that it lacks a lot of error definitions for operations.
Here is a list of all the operations that have errors defined:

$ node -e 'm=require("./smithy-rs/aws/sdk/aws-models/s3.json"); Object.entries(m.shapes).forEach(([n,s])=>{ if (s.type==="operation" && s.errors) console.log(n, "---", s.errors.map(x=>x.target).join(",")); })'
com.amazonaws.s3#AbortMultipartUpload --- com.amazonaws.s3#NoSuchUpload
com.amazonaws.s3#CopyObject --- com.amazonaws.s3#ObjectNotInActiveTierError
com.amazonaws.s3#CreateBucket --- com.amazonaws.s3#BucketAlreadyExists,com.amazonaws.s3#BucketAlreadyOwnedByYou
com.amazonaws.s3#GetObject --- com.amazonaws.s3#InvalidObjectState,com.amazonaws.s3#NoSuchKey
com.amazonaws.s3#GetObjectAcl --- com.amazonaws.s3#NoSuchKey
com.amazonaws.s3#HeadBucket --- com.amazonaws.s3#NotFound
com.amazonaws.s3#HeadObject --- com.amazonaws.s3#NotFound
com.amazonaws.s3#ListObjects --- com.amazonaws.s3#NoSuchBucket
com.amazonaws.s3#ListObjectsV2 --- com.amazonaws.s3#NoSuchBucket
com.amazonaws.s3#PutObjectAcl --- com.amazonaws.s3#NoSuchKey
com.amazonaws.s3#RestoreObject --- com.amazonaws.s3#ObjectAlreadyInActiveTierError

This is clearly a tiny fraction of the real errors that this API can return.
See https://docs.aws.amazon.com/AmazonS3/latest/API/ErrorResponses.html

Is there a way to contribute to the model definition to make it represent the S3 errors correctly?

Thanks!

@kellertk
Copy link
Contributor Author

P62314171

@kellertk
Copy link
Contributor Author

Hi everyone, this will require some changes from the S3 service team in how these errors are modeled. We raised this request up to the team and they've agreed to put it on their feature backlog. We don't have any ETA at this time, but I would expect a timeframe of at least a few months before this will be reviewed further. If there are other updates from the team, we will post them here.

@yasminetalby yasminetalby self-assigned this Jun 13, 2023
@ashishdhingra
Copy link

Reached out to service team for an update. Awaiting response.

@guymguym
Copy link

FYI @Nugine for the https://github.com/Nugine/s3s project

@ashishdhingra
Copy link

Got update from service team. It's in their prioritized list of feature requests. We can't share specific timelines on when this might be implemented in GitHub; you should monitor the AWS News Blog for updates.

Closing this issue since the feature is prioritized in service team's backlog.

Copy link

This issue is now closed.

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
s3 service-api This issue pertains to the AWS API
Projects
None yet
Development

No branches or pull requests

4 participants