Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support minimum-trust workspace #1823

Open
justinmk3 opened this issue Jun 21, 2021 · 1 comment
Open

Support minimum-trust workspace #1823

justinmk3 opened this issue Jun 21, 2021 · 1 comment
Labels
feature-request New feature or enhancement. May require GitHub community feedback. filesystem network

Comments

@justinmk3
Copy link
Contributor

from #1821:

VS code 1.57 introduced a 'trust' feature that is applied to the current workspace, restricting extension access based on trust level. The insiders build allows individual extensions to have a trust level, by default they are untrusted. Untrusted extensions cannot be activated, thus failing the test. We are not particularly concerned with this functionality in regards to other extensions, so we will just disable it entirely when testing.

We should look into this more for our own extension as far as UX is concerned (what should our extension be capable of given a minimum trust level?)

Refer to this issue: microsoft/vscode#120251

Considerations for the toolkit (to be added to package.json):

capabilities:
	untrustedWorkspaces:
		{ supported: true } |
		{ supported: false, description: string } |
		{ supported: 'limited', description: string, restrictedConfigurations?: string[] }

By default, extensions do not support untrusted workspaces. This seems to be the best option for the toolkit for now. In other words, we do not need to update anything unless we want to add a description string for why we do not support untrusted workspaces.

Proposal

  • Most Toolkit features don't need to write to the workspace, so we should be able to support untrusted model.
    • remote AWS explorer mostly reads/writes to the network (what trust level does network access require?)
    • CDK explorer can display its tree with just "read" access to the filesystem
  • Trust is needed for:
    • write-level access: CDK deploy, SAM local run/debug
    • ?
@justinmk3 justinmk3 added the feature-request New feature or enhancement. May require GitHub community feedback. label Jun 21, 2021
@justinmk3
Copy link
Contributor Author

justinmk3 commented Oct 20, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature or enhancement. May require GitHub community feedback. filesystem network
Projects
None yet
Development

No branches or pull requests

1 participant