Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support string output path in EvalAlgorithmInterface.evaluate(save="...") #165

Open
athewsey opened this issue Jan 9, 2024 · 3 comments

Comments

@athewsey
Copy link
Contributor

athewsey commented Jan 9, 2024

Today the save parameter of EvalAlgorithmInterface.evaluate() is just a boolean.

From hunting around I found that the output path is taken either from an environment variable or else a default under /tmp... And that it should also be overrideable by setting the obviously-supposed-to-be-private property eval_algo._eval_results_path.

IMO it's harder and less obvious than it should be for a developer using the library to save results in a folder they want. It'd be much easier if we could support eval_algo.evaluate(save="my/cool/folder") and ideally automatically create the provided folder if it doesn't already exist?

@keerthanvasist
Copy link
Member

Thanks for bringing this up @athewsey! What you said seems to make absolute sense. We will take another look at this decision, why it was done this way, and if there isn't one, we will update it soon.

@athewsey
Copy link
Contributor Author

athewsey commented May 3, 2024

Any update on this? Would be useful to be able to actually save evaluation results where we want

@keerthanvasist
Copy link
Member

This is in our backlog. We are currently evaluating different proposals. We will update this soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants