Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When generating .NET code, convert non-default namespace parts to PascalCase. #174

Closed
mpiroc opened this issue Aug 13, 2018 · 2 comments
Closed

When generating .NET code, convert non-default namespace parts to PascalCase. #174

mpiroc opened this issue Aug 13, 2018 · 2 comments
Labels
closed-for-staleness effort/medium Medium work item – a couple days of effort language/dotnet Related to .NET bindings (C#, F#, ...) p2

Comments

@mpiroc
Copy link
Contributor

mpiroc commented Aug 13, 2018

Currently, if a JSII type's namespace is a child of the default namespace, the child namespace is not PascalCased. For example, jsii-calc.composition.CompositeOperation has the namespace Amazon.JSII.Tests.CalculatorNamespace.composition, when it should be Amazon.JSII.Tests.CalculatorNamespace.Composition.
@mpiroc mpiroc mentioned this issue Aug 13, 2018
Merged
@mpiroc mpiroc added the language/dotnet Related to .NET bindings (C#, F#, ...) label Oct 25, 2018
@fulghum fulghum added the p0 label Apr 2, 2019
@fulghum fulghum added the effort/medium Medium work item – a couple days of effort label Apr 22, 2019
@RomainMuller RomainMuller added this to the .NET Support milestone Jul 30, 2019
@assyadh assyadh added p1 and removed p0 labels Aug 20, 2019
@assyadh
Copy link
Contributor

assyadh commented Aug 20, 2019

After discussing with @RomainMuller , downgrading the priority as namespaces are likely to go away.

@RomainMuller RomainMuller added p2 and removed p1 labels Dec 10, 2019
@RomainMuller RomainMuller removed this from the .NET Support milestone Jul 21, 2020
@MrArnoldPalmer MrArnoldPalmer removed their assignment Jun 28, 2021
@github-actions
Copy link
Contributor

This issue has not received any attention in 2 years. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added closing-soon This issue will automatically close in 4 days unless further comments are made. closed-for-staleness and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Jun 29, 2023
@github-actions github-actions bot closed this as completed Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed-for-staleness effort/medium Medium work item – a couple days of effort language/dotnet Related to .NET bindings (C#, F#, ...) p2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@fulghum @RomainMuller @mpiroc @assyadh @MrArnoldPalmer