Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiling s2n-quic-platform on musl #2038

Closed
yixinin opened this issue Nov 17, 2023 · 3 comments
Closed

Compiling s2n-quic-platform on musl #2038

yixinin opened this issue Nov 17, 2023 · 3 comments
Labels
ci Tasks related to ci

Comments

@yixinin
Copy link
Contributor

yixinin commented Nov 17, 2023

ENV:

Host:
Linux 8cbeb297efdc 5.10.0-23-amd64 #1 SMP Debian 5.10.179-1 (2023-05-12) x86_64 Linux

rustup host:
x86_64-unknown-linux-musl (in docker rust:alpine)
target:
x86_64-unknown-linux-musl

Problem:

error[E0308]: mismatched types
--> /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/s2n-quic-platform-0.31.0/src/syscall/mmsg.rs:140:52
|
140 | let res = libc!(recvmmsg(sockfd, msgvec, vlen, flags, timeout));
| ^^^^^ expected u32, found i32
note: function defined here
--> /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/libc-0.2.150/src/unix/linux_like/linux/musl/mod.rs:723:12
|
723 | pub fn recvmmsg(
| ^^^^^^^^
help: you can convert an i32 to a u32 and panic if the converted value doesn't fit
|
140 | let res = libc!(recvmmsg(sockfd, msgvec, vlen, flags.try_into().unwrap(), timeout));
| ++++++++++++++++++++

@camshaft
Copy link
Contributor

I tried compiling the entire workspace for musl and it looks like there's a few other issues with aws-lc-rs and s2n-tls that need to be addressed before we can add a CI task to prevent future regressions.

This PR should fix the s2n-tls issue: aws/s2n-tls#4295

Still investigating the aws-lc-rs issue: https://gist.github.com/camshaft/95441e79397186398d4455e8e820a7a9

@camshaft camshaft added the ci Tasks related to ci label Nov 30, 2023
@camshaft
Copy link
Contributor

The aws-lc-rs issue should be fixed by aws/aws-lc-rs#283

@camshaft
Copy link
Contributor

camshaft commented Aug 8, 2024

Fixed in #2102

@camshaft camshaft closed this as completed Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Tasks related to ci
Projects
None yet
Development

No branches or pull requests

2 participants