Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry metric middleware probably shouldn't return error if no retry metadata #163

Closed
jasdel opened this issue Sep 2, 2020 · 1 comment
Closed
Labels
bug This issue is a bug.

Comments

@jasdel
Copy link
Contributor

jasdel commented Sep 2, 2020

The retry metric middleware will return an error if it cannot find the retry metadata in the middleware context. This middleware should most likely just forward on the request instead of errorring out.

https://github.com/aws/aws-sdk-go-v2/blob/223893cb4d9d2da39d7f82d87a8614f0f8c95bbe/aws/retry/middleware.go#L132-L135

@jasdel
Copy link
Contributor Author

jasdel commented Dec 7, 2020

created in v2 SDK repo.

@jasdel jasdel closed this as completed Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug.
Projects
None yet
Development

No branches or pull requests

1 participant