Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support c2s AWS environments #433

Closed
jrsherry opened this issue Nov 8, 2022 · 6 comments
Closed

Support c2s AWS environments #433

jrsherry opened this issue Nov 8, 2022 · 6 comments
Milestone
0.8.0

Comments

@jrsherry
Copy link
Contributor

jrsherry commented Nov 8, 2022

The regex for determining if the ECR URI is valid needs to be updated to support c2s AWS environments.
@jrsherry
Copy link
Contributor Author

jrsherry commented Nov 8, 2022

An example of this can be found here: https://github.com/kubernetes/kubernetes/pull/113087/files

@jrsherry
Copy link
Contributor Author

jrsherry commented Nov 8, 2022

One solution for this issue has been pulled here: #326

@jrsherry
Copy link
Contributor Author

jrsherry commented Nov 8, 2022

Here's a PR that picks up the pattern used in mainline kubernetes: https://github.com/awslabs/amazon-ecr-credential-helper/pull/434/files

@thecodebeneath
Copy link

Our project could benefit from this PR solution c2s environments. Upvote.

@ghost
Copy link

ghost commented Jan 8, 2024

Here's a PR that picks up the pattern used in mainline kubernetes: https://github.com/awslabs/amazon-ecr-credential-helper/pull/434/files

It would be great to have this PR looked at!

@austinvazquez austinvazquez mentioned this issue Jan 8, 2024
Merged
@austinvazquez austinvazquez added this to the 0.8.0 milestone Apr 29, 2024
@austinvazquez
Copy link
Contributor

Issue resolved by #434 and will be included in 0.8.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.8.0
Development

No branches or pull requests
3 participants
@jrsherry @thecodebeneath @austinvazquez