Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using this credential helper prevents you from pulling from docker hub #474

Open
sterling000 opened this issue Jan 26, 2023 · 5 comments
Open

Comments

@sterling000
Copy link

pretty easy to reproduce
follow the setup instructions
configure with the credsStore ecr-login (the credHelpers never worked for me)
pull an image from your private repo
then call docker login

Observe Error:
Error saving credentials: error storing credentials - err: exit status 1, out: not implemented

@86ribeiro
Copy link

Same problem here.

@niroliyanage
Copy link

same issue here had to override the DOCKER_CONFIG='~./docker/bla.json' to get it to work with other repositories

@hannes-ucsc
Copy link

What fixed this for me was to change

{
	"credsStore": "ecr-login"
}

to

{
	"credHelpers": {
		"public.ecr.aws": "ecr-login",
		"<aws_account_id>.dkr.ecr.<region>.amazonaws.com": "ecr-login"
	}
}

in ~/.docker/config.json so that Docker doesn't attempt to store docker.io (or any other registry's) credentials using this helper.

Both options are mentioned in the documentation but the latter is more interoperable, so I think the documentation should be updated to give more prominence to it. Many people will come here with limited knowledge of Docker credential helpers, as did I, and it will take them a while to understand what's going on.

@xocasdashdash
Copy link

@hannes-ucsc are you able to still do:

 aws --region us-east-1 ecr get-login-password | docker login --username AWS --password-stdin XXXX.dkr.ecr.us-east-1.amazonaws.com

with that config? because i have that exact config and it's failing with

Error saving credentials: error storing credentials - err: exit status 1, out: `not implemented`

@hannes-ucsc
Copy link

I don't know. I don't use docker login in contexts where the helper is installed. I thought the point of this helper is that one doesn't need to use docker login.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants