Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add testing for Windows platform to CI #790

Closed
austinvazquez opened this issue Apr 23, 2024 · 0 comments · Fixed by #788
Closed

Add testing for Windows platform to CI #790

austinvazquez opened this issue Apr 23, 2024 · 0 comments · Fixed by #788
Labels
github_actions Pull requests that update GitHub Actions code
Milestone
0.8.0

Comments

@austinvazquez
Copy link
Contributor

Issue

Beginning with v0.3.1, there has been officially GitHub releases for Windows x86 variant. Added in #782, the Windows ARM variant will be included in the next release.

The concern is there exists no testing for the Windows platform.

Recommended solution

The recommendation is to run credential helper unit tests on the Windows platform as part of CI. This should give some confidence for the Windows variants and can be expanded if needed.
@austinvazquez austinvazquez added this to the 0.8.0 milestone Apr 23, 2024
@austinvazquez austinvazquez added the github_actions Pull requests that update GitHub Actions code label Apr 23, 2024
@austinvazquez austinvazquez mentioned this issue Apr 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Milestone
0.8.0
Development

Successfully merging a pull request may close this issue.

Add windows to ci austinvazquez/amazon-ecr-credential-helper
1 participant
@austinvazquez