Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cloudfront): add lambda association #2760

Merged
merged 4 commits into from
Jun 12, 2019
Merged

feat(cloudfront): add lambda association #2760

merged 4 commits into from
Jun 12, 2019

Conversation

KnisterPeter
Copy link
Contributor

@KnisterPeter KnisterPeter commented Jun 5, 2019 •
edited
Loading

This enables to associate a lambda to a distribution behaviour.
The lambda could be associated with the four available event-types.

Pull Request Checklist

  • Testing
    • Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking change)
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
    • Design: For significant features, design document added to design folder
  • Title and Description
    • Change type: title prefixed with fix, feat and module name in parens, which will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

@KnisterPeter KnisterPeter requested a review from a team as a code owner June 5, 2019 16:08
@KnisterPeter
Copy link
Contributor Author

This PR relates to #1575, but it does not fix the entire issue

@KnisterPeter
feat(cloudfront): add lambda association
9fc8b00 
This enables to associate a lambda to a distribution behaviour.
The lambda could be associated with the four available event-types.
@KnisterPeter
fix(cloudfront): use lambda version instead of lambda for association
02d7bfb 
The lambda associations requires a lambda version ARN instead of the
function ARN.
This in turn requires the exposure of the versionArn from the lambda
version template.
@KnisterPeter
Copy link
Contributor Author

KnisterPeter commented Jun 12, 2019 •
edited
Loading

@rix0rrr Updated this PR and integrated all our requests

But there are still parts missing... Right now I could not get my lambda to deploy. I'll investigate and update this when I've managed to fix it.

@rix0rrr rix0rrr merged commit b088c8c into aws:master Jun 12, 2019
ScOut3R pushed a commit to ScOut3R/aws-cdk that referenced this pull request Jun 13, 2019
@KnisterPeter @ScOut3R
feat(cloudfront): add Lambda associations (aws#2760)
2d37946 
This enables to associate a lambda to a distribution behaviour. The lambda could be associated with the four available event-types.
@KnisterPeter KnisterPeter deleted the cloudfront-lambda-edge branch June 20, 2019 08:21
This was referenced Aug 22, 2019
Open
Open
Open
Open
Open
This was referenced Dec 12, 2019
Closed
Closed
Closed
Merged
Closed
Closed
Open
Open
Open
Open
This was referenced Dec 12, 2019
Open
Open
Open
Open
Open
Open
This was referenced Jan 20, 2020
Closed
Closed
This was referenced Sep 24, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
@NOUIY NOUIY mentioned this pull request Oct 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rix0rrr rix0rrr rix0rrr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KnisterPeter @rix0rrr