Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Record DependableTrait directly on instance #2962

Merged
merged 1 commit into from
Jun 20, 2019

Conversation

RomainMuller
Copy link
Contributor

The use of the WeakMap caused difficulties for construct library authors, because they
could occasionally operate on a different instance of the @aws-cdk/cdk library.

Fixes #2713


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

The use of the WeakMap caused difficulties for construct library authors, because they
could occasionally operate on a different instance of the @aws-cdk/cdk library.

Fixes #2713
@RomainMuller RomainMuller requested a review from a team as a code owner June 20, 2019 13:53
@orangewise
Copy link
Contributor

Awesome, thanks!

@RomainMuller RomainMuller merged commit e535929 into master Jun 20, 2019
@RomainMuller RomainMuller deleted the rmuller/dependencies branch June 20, 2019 14:57
@NGL321 NGL321 added the contribution/core This is a PR that came from AWS. label Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

External libraries in v0.33.0 throwing ${instance} does not implement DependableTrait
5 participants