fix(stepfunctions): Downscope SageMaker permissions #2991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous implementation was using the `SageMakerFullAccess` managed policy, which grants extensive permissions to the SageMaker job. Instead, this commit makes it set permissions very specifically to what the requirement entities are, and only resorts to the `*` resource when the entities are provided by an input to the StepFunction.
rix0rrr
reviewed
Jun 21, 2019
packages/@aws-cdk/aws-stepfunctions-tasks/lib/sagemaker-task-base-types.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-stepfunctions-tasks/lib/sagemaker-task-base-types.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-stepfunctions-tasks/lib/sagemaker-task-base-types.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-stepfunctions-tasks/lib/sagemaker-task-base-types.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-stepfunctions-tasks/lib/sagemaker-task-base-types.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-stepfunctions-tasks/lib/sagemaker-train-task.ts
Outdated
Show resolved
Hide resolved
rix0rrr
approved these changes
Jul 2, 2019
eladb
approved these changes
Jul 2, 2019
Kaixiang-AWS
pushed a commit
to Kaixiang-AWS/aws-cdk
that referenced
this pull request
Jul 3, 2019
Previous implementation was using the `SageMakerFullAccess` managed policy, which grants extensive permissions to the SageMaker job. Instead, this commit makes it set permissions very specifically to what the requirement entities are, and only resorts to the `*` resource when the entities are provided by an input to the StepFunction.
This was referenced Aug 22, 2019
This was referenced Dec 12, 2019
This was referenced Dec 12, 2019
This was referenced Jan 20, 2020
This was referenced Sep 24, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous implementation was using the
SageMakerFullAccessmanagedpolicy, which grants extensive permissions to the SageMaker job.
Instead, this commit makes it set permissions very specifically to what
the requirement entities are, and only resorts to the
*resource whenthe entities are provided by an input to the StepFunction.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.