refactor(core): rename "Stack.autoRun" to "autoSynth" #3016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: `StackProps.autoRun` was renamed to `StackProps.autoSynth`.
shivlaks
approved these changes
Jun 23, 2019
shivlaks
reviewed
Jun 23, 2019
packages/@aws-cdk/cdk/lib/app.ts
Outdated
| * | ||
| * If you set this, you don't have to call `synth()` anymore. | ||
| * If you set this, you don't have to call `synth()` explicitly. Note that | ||
| * this feature is only available for certain programming languages, and |
There was a problem hiding this comment.
which languages are supported / which ones are not?
There was a problem hiding this comment.
I am not 100% sure TBH. I think some jsii languages don't implement the exit hook properly and I wanted to set expectations that this is not 100% working... We need to fix it obvsiouly and then remove this warning.
rix0rrr
approved these changes
Jun 23, 2019
This was referenced Aug 22, 2019
|
Thanks so much for taking the time to contribute to the AWS CDK ❤️ We will shortly assign someone to review this pull request and help get it
|
This was referenced Dec 12, 2019
This was referenced Jan 20, 2020
This was referenced Sep 24, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
StackProps.autoRunwas renamed toStackProps.autoSynth.Please read the contribution guidelines and follow the pull-request checklist.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license