Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make internals private? #129

Closed
stefanofornari opened this issue Jul 27, 2023 · 4 comments
Closed

Make internals private? #129

stefanofornari opened this issue Jul 27, 2023 · 4 comments

Comments

@stefanofornari
Copy link
Contributor

aws-java-nio-spi-for-s3/src/main/java/software/amazon/nio/spi/s3/S3FileSystemProvider.java

Line 326 in 20c8e9c

protected Iterator<Path> pathIteratorForPublisher(

Given that when we have a protected member we want to pay extra attention to the stability of the interface, which makes the codebase more difficult to refactor, would it make sense to make this private?
@markjschreiber
Copy link
Contributor

I think it is protected because of a limitation of unit testing that cannot test private methods. It could probably be hidden with a refactoring of the unit test?

@markjschreiber
Copy link
Contributor

Using reflection would be an alternative way to test a private method. If it must be tested.

@stefanofornari
Copy link
Contributor Author

Yep, despite I agree that testability justifies not optimal design choices, either we are more flexible in compatibility breaking changes or more careful in using it.
Either ways work for me. would you take care of it?

@stefanofornari stefanofornari mentioned this issue Aug 5, 2023
Merged
@stefanofornari
Copy link
Contributor Author

merged into main with PR #133

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stefanofornari @markjschreiber