Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding AssertJ (issue #59) #100

Merged
merged 8 commits into from
Jul 10, 2023
Merged

Conversation

stefanofornari
Copy link
Contributor

*Issue #59 *

Description of changes:

  • Adding AssertJ
  • Bumping java to 16 otherwise I had an error with logback
  • added some more builder/IDE files to ignore

As an example of using assertj, I changed S3SpiConfigurationTest

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

- Bumping java to 16 otherwise I had an error with logback
- added some more builder/IDE files to ignore
This reverts commit 2697125d74b4c9bb0fb5c06be847cdb3531d569c.
@stefanofornari
Copy link
Contributor Author

sorry for the mess...

@markjschreiber markjschreiber merged commit 1952849 into awslabs:main Jul 10, 2023
1 check passed
stefanofornari pushed a commit to stefanofornari/aws-java-nio-spi-for-s3 that referenced this pull request Jul 10, 2023
* adding Assertj

---------

Co-authored-by: Mark Schreiber <[email protected]>
@stefanofornari stefanofornari deleted the upstream#59 branch November 7, 2023 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants