Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove .DS_Store #193

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Conversation

guicamest
Copy link
Contributor

Description of changes:
This PR removes the .DS_Store from src. It is already added to .gitignore, so no need to add it there.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@markjschreiber markjschreiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this cleanup

@markjschreiber
Copy link
Contributor

For some reason github is still failing this after the fixes to the tests to close the filesystem(s). It may be that you will need to rebase this PR onto the latest version of main so that it picks up the relevant changes.

Alternatively you could close this PR and submit a new one.

@guicamest
Copy link
Contributor Author

You're welcome! I have just rebased and the action succeeded 🎉

@markjschreiber markjschreiber merged commit a97cc27 into awslabs:main Oct 3, 2023
1 check passed
@guicamest guicamest deleted the removeDSStore branch October 3, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants