Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(java): Upgrade to java 11 #242

Merged
merged 7 commits into from
Oct 30, 2023
Merged

Conversation

guicamest
Copy link
Contributor

@guicamest guicamest commented Oct 30, 2023

Description of changes:

Compile and target jvm >= 11 for version 2.x according to #228 (comment).

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@markjschreiber markjschreiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks! I will let you merge this and the other PRs in the order you prefer.

@guicamest
Copy link
Contributor Author

This could be the third one to merge, I don't have a merge option unfortunately 😬

@markjschreiber
Copy link
Contributor

This could be the third one to merge, I don't have a merge option unfortunately 😬

No problem I will merge them for you. I will take a look at the merge rules. It may be that you can't because of the org ownership.

@markjschreiber markjschreiber merged commit f0e0b29 into awslabs:main Oct 30, 2023
1 check passed
@guicamest guicamest deleted the java11 branch October 30, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants