Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve maintainability / readability / javadoc #251

Merged
merged 14 commits into from
Nov 2, 2023
Merged

Improve maintainability / readability / javadoc #251

merged 14 commits into from
Nov 2, 2023

Conversation

guicamest
Copy link
Contributor

Description of changes:

This PR addresses some suggestions of the IDE:

  • Unnecessary types
  • Unnecessary variable initialization
  • Replace one liner lambdas with expression lambdas
  • Declared exceptions that are not thrown
  • Replace assertTrue(x instanceof b) with assertThat().isInstanceOf
  • Use collection.isEmpty() when possible

For the cases where Unnecessary variable initialization was found, the code has been rewritten with smaller methods, making the code easier to understand (see 2da3ec0 for example)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@guicamest
cleanup: Run code cleanup in IDE
60169a6
@guicamest
Use cache within getFileSystem in S3FileSystemProvider; removes
88ce3fb 
redundant initializer warning
@guicamest
cleanup: Unnecessary check of cache in forUri
9edc823
@guicamest
chore(S3FileSystemProvider): use Map.computeIfAbsent to simplify code
27dbdd5
@guicamest
chore(S3FileSystemProvider): Add S3FileSystemInfo to forUri to avoi…
b351710 
…d recalculating it
@guicamest
refactor(S3Path): extract methods to use in getPath to improve code…
2da3ec0 
… maintainance and readability; solves unused assignment warning on `part`
@guicamest
refactor(S3Path): extract scheme variable
eb58bd6
@guicamest
docs(newFileSystem): Convert comment to javadoc
3bf1e3f
@guicamest
cleanup: replace lambda with method reference
d21da6d
@guicamest
cleanup: Remove declared exceptions that are never thrown
82877a4
@guicamest
cleanup: Remove unnecessary Path type
e8a6aab
@guicamest
chore: replace lambda statement with expression
7de43b1
@guicamest
rewrite: Replace assertTrue(x instanceof b) with `assertThat().isIn…
e3c5480 
…stanceOf`
@guicamest
migration(java11): Use collection.isEmpty() when possible
d2d93da
@guicamest guicamest changed the title Code cleanup ide Improve maintainability / readability / javadocs Nov 2, 2023
@guicamest guicamest changed the title Improve maintainability / readability / javadocs Improve maintainability / readability / javadoc Nov 2, 2023
markjschreiber
markjschreiber approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@markjschreiber markjschreiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@markjschreiber markjschreiber merged commit 68179cf into awslabs:main Nov 2, 2023
1 check passed
@guicamest guicamest deleted the codeCleanupIDE branch November 2, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markjschreiber markjschreiber markjschreiber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guicamest @markjschreiber