fix: fixes refreshing expired credentials by preventing DefaultCredentialsProvider from being autoclosed #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…using role assumption
sberss
force-pushed
the
fix-auth-with-role-assumption
branch
from
176e394
to
c38610d
Compare
|
No worries! Any chance I could get this and #499 in a new release? |
stefanofornari
pushed a commit
to stefanofornari/aws-java-nio-spi-for-s3
that referenced
this pull request
Aug 6, 2024
…using role assumption (awslabs#498)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #494
Pulls the client instantiation out of the
try-with-resourceblock to stop it being closed and therefore not usable when refreshing expired credentials.