feat(aws-cloudfront-apigateway-lambda): added cloudFrontLoggingBucketProps to cloudfront-apigateway-lambda #455
Conversation
mickychetta
requested review from
biffgaut,
hayesry and
hnishar
as code owners
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
…onstructs into 418_cloudfront-gateway-lambda
…ckychetta/aws-solutions-constructs into 418_cloudfront-gateway-lambda
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
| "Arn" | ||
| ] | ||
| }, | ||
| BucketName: { |
There was a problem hiding this comment.
If this is the check that the bucket was created correctly, let's check for autoDeleteObjects and/or removalPolicy rather than the name. This will ensure the correct type of bucket is found and will be less brittle in the event something causes the bucket name to change in the future.
There was a problem hiding this comment.
Lines 232-243 checks the autoDeleteObject: true on the specific CloudFront Logging Bucket:
expect(stack).toHaveResource("Custom::S3AutoDeleteObjects", {
ServiceToken: {
"Fn::GetAtt": [
"CustomS3AutoDeleteObjectsCustomResourceProviderHandler9D90184F",
"Arn"
]
},
BucketName: {
Ref: "testcloudfrontapigatewaylambdaCloudFrontToApiGatewayCloudfrontLoggingBucket7F467421"
}
});```
There was a problem hiding this comment.
The bucket name is still going to be brittle, but we'll leave it in for now. If it becomes a problem we can drop it later.
| "Arn" | ||
| ] | ||
| }, | ||
| BucketName: { |
There was a problem hiding this comment.
The bucket name is still going to be brittle, but we'll leave it in for now. If it becomes a problem we can drop it later.
Issue #418 , if available:
Description of changes:
-Exposed optional cloudFrontLoggingBucketProps to cloudfront-apigateway-lambda
-Created new tests for cloudfront logging bucket
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.