feat(aws-iot-s3): new construct implementation #469

surukonda · 2021-10-25T15:18:59Z

Issue #, if available:

Description of changes:
New aws-iot-s3 solutions construct implementation

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

aws-solutions-constructs-team · 2021-10-25T15:23:16Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: 652ce0c
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-solutions-constructs-team · 2021-10-25T15:27:46Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v1
Commit ID: 652ce0c
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

…ns-constructs into aws-iot-s3

aws-solutions-constructs-team · 2021-10-25T15:33:22Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: 27fbc93
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-solutions-constructs-team · 2021-10-25T15:34:34Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v1
Commit ID: 014e702
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-solutions-constructs-team · 2021-10-25T15:35:16Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: 014e702
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-solutions-constructs-team · 2021-10-25T15:37:39Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v1
Commit ID: 27fbc93
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-solutions-constructs-team · 2021-10-25T17:02:51Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: 0201e70
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-solutions-constructs-team · 2021-10-25T17:04:02Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: a307fd2
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-solutions-constructs-team · 2021-10-25T17:07:37Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v1
Commit ID: 0201e70
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-solutions-constructs-team · 2021-10-25T17:08:45Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v1
Commit ID: a307fd2
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-solutions-constructs-team · 2021-10-26T01:47:24Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: d1582b4
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-solutions-constructs-team · 2021-10-26T01:47:50Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: e1ee7ec
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-solutions-constructs-team · 2021-10-26T01:49:43Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v1
Commit ID: d1582b4
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-solutions-constructs-team · 2021-10-26T01:50:00Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v1
Commit ID: e1ee7ec
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

biffgaut

Several questions - the answers might lead to requests for changes.

biffgaut · 2021-10-28T13:25:13Z

source/patterns/@aws-solutions-constructs/aws-iot-s3/README.md

+|:-------------|:----------------|-----------------|
+|existingBucketObj?|[`s3.IBucket`](https://docs.aws.amazon.com/cdk/api/latest/docs/@aws-cdk_aws-s3.IBucket.html)|Existing instance of S3 Bucket object. Providing this property and `bucketProps` results in an error.|
+|bucketProps?|[`s3.BucketProps`](https://docs.aws.amazon.com/cdk/api/latest/docs/@aws-cdk_aws-s3.BucketProps.html)|Optional user provided props to override the default props for the S3 Bucket. Providing this and `existingBucketObj` reults in an error.|
+|loggingBucketProps?|[`s3.BucketProps`](https://docs.aws.amazon.com/cdk/api/latest/docs/@aws-cdk_aws-s3.BucketProps.html)|Optional user provided props to override the default props for the S3 Logging Bucket.|


We'll take care of this after merge, but just FYI we've added another prop - a boolean flag allowing clients to turn off Access Logging (defaults to true)

biffgaut · 2021-10-28T13:26:30Z

source/patterns/@aws-solutions-constructs/aws-iot-s3/README.md

+|bucketProps?|[`s3.BucketProps`](https://docs.aws.amazon.com/cdk/api/latest/docs/@aws-cdk_aws-s3.BucketProps.html)|Optional user provided props to override the default props for the S3 Bucket. Providing this and `existingBucketObj` reults in an error.|
+|loggingBucketProps?|[`s3.BucketProps`](https://docs.aws.amazon.com/cdk/api/latest/docs/@aws-cdk_aws-s3.BucketProps.html)|Optional user provided props to override the default props for the S3 Logging Bucket.|
+|iotTopicRuleProps?|[`iot.CfnTopicRuleProps`](https://docs.aws.amazon.com/cdk/api/latest/docs/@aws-cdk_aws-iot.CfnTopicRuleProps.html)|User provided CfnTopicRuleProps to override the defaults.|
+|s3Key|`string`|User provided s3Key to override the default (`${topic()}/${timestamp()}`) object key. Used to store messages matched by the IoT Rule.|


Help me out with this - it's not listed in the interface for IoT nor S3. Is it a concept unique to the combination of these two services?

It is a unique prop for this construct. This is one of the required properties for s3ActionProperty. Details can be found here

biffgaut · 2021-10-28T14:20:28Z

source/patterns/@aws-solutions-constructs/aws-iot-s3/lib/index.ts

+    });
+
+    // Setup the IAM policy for IoT Actions
+    const iotActionsPolicy = new iam.Policy(this, 'IotActionsPolicy', {


Can't this be handled with a bucket.grantWrite() call, similar to aws-iot-sqs?

I will update it

biffgaut · 2021-10-28T14:25:00Z

source/patterns/@aws-solutions-constructs/aws-iot-s3/test/integ.iot-s3-defaultprops.ts

+const app = new App();
+const stack = new Stack(app, generateIntegStackName(__filename));
+
+const props: IotToS3Props = {


Let's send bucket props and loggingBucketProps with deleteAllObjects: true and REMOVAL-POLICY.destroy so that the test cleans itself up completely. Many of our recent changes is to ensure that clients can set up their constructs to be completely destroyed and we will be changing existing integration tests to do so.

ok, I will change the test cases and update the PR

biffgaut · 2021-10-28T14:26:34Z

source/patterns/@aws-solutions-constructs/aws-iot-s3/test/integ.iot-s3-newbucket.ts

+      actions: []
+    }
+  },
+  bucketProps: {


integ.iot-s3-defaultprops.ts is also a new bucket, what makes this unique is sending bucket props. If you make the removal and delete all objects changes then these tests are essentially the same.

Bucket encryption is different, I was making sure the construct can write to a bucket with different encryption types supported by S3

biffgaut · 2021-10-28T14:27:14Z

source/patterns/@aws-solutions-constructs/aws-iot-s3/test/integ.iot-s3-overrideprops.ts

+      actions: []
+    }
+  },
+  existingBucketObj,


Again, name seems off. This is not override props, this is existing bucket.

I will align the names with existing constructs

aws-solutions-constructs-team · 2021-10-29T06:06:06Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: f77ae3f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-solutions-constructs-team · 2021-10-29T06:08:14Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v1
Commit ID: f77ae3f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-solutions-constructs-team · 2022-01-03T08:27:23Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v1
Commit ID: 583471f
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-solutions-constructs-team · 2022-01-03T08:28:04Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: 583471f
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-solutions-constructs-team · 2022-01-03T17:35:10Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: fe3313a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-solutions-constructs-team · 2022-01-03T17:35:14Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v1
Commit ID: fe3313a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

…ns-constructs into aws-iot-s3

aws-solutions-constructs-team · 2022-01-03T18:01:22Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: 5d8ac6a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-solutions-constructs-team · 2022-01-03T18:04:35Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v1
Commit ID: 5d8ac6a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-solutions-constructs-team · 2022-01-04T13:20:01Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: 995cf8f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-solutions-constructs-team · 2022-01-04T13:20:38Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v1
Commit ID: 995cf8f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

biffgaut

Didn't fully check it out, but had a few minutes and saw some updates needed so thought I'd get them to you ASAP.

biffgaut · 2022-01-04T21:31:33Z

source/patterns/@aws-solutions-constructs/aws-iot-s3/lib/index.ts

@@ -112,7 +110,7 @@ export class IotToS3 extends Construct {
    this.iotTopicRule = new iot.CfnTopicRule(this, 'IotTopicRule', iotTopicProps);

    // If bucket has a KMS CMK, explicitly provide IoTActionsRole necessary access to write to the bucket
-    if (this.s3Bucket && this.s3Bucket.encryptionKey) {
+    if (this.s3Bucket && this.s3Bucket.encryptionKey && props.existingBucketObj) {


I don't get this - doesn't the role need access to the KMS key for the bucket regardless of whether the bucket is new or was supplied by the client?

biffgaut · 2022-01-04T21:37:05Z

source/patterns/@aws-solutions-constructs/aws-iot-s3/README.md

@@ -64,6 +64,7 @@ _Parameters_
 |loggingBucketProps?|[`s3.BucketProps`](https://docs.aws.amazon.com/cdk/api/latest/docs/@aws-cdk_aws-s3.BucketProps.html)|Optional user provided props to override the default props for the S3 Logging Bucket.|
 |iotTopicRuleProps?|[`iot.CfnTopicRuleProps`](https://docs.aws.amazon.com/cdk/api/latest/docs/@aws-cdk_aws-iot.CfnTopicRuleProps.html)|User provided CfnTopicRuleProps to override the defaults.|
 |s3Key|`string`|User provided s3Key to override the default (`${topic()}/${timestamp()}`) object key. Used to store messages matched by the IoT Rule.|
+|logS3AccessLogs?|`boolean`|Whether to turn on Access Logging for the S3 bucket. Creates an S3 bucket with associated storage costs for the logs. Enabling Access Logging is a best practice. default - true|

 ## Pattern Properties



Properties needs to expose s3BucketInterface: s3:IBucket as well. You accept IBucket as an input - if the client sends an IBucket, how do you populate this non-optional property with an s3.Bucket? The old constructs aren't consistent on this, but where we want to be is a construct accepts an IBucket or Bucket as a prop (but not both).

If a construct accepts IBucket, then it exposes Bucket and IBucket at properties. If it receives an IBucket then it populates just s3BucketInterface. If it creates a new bucket, then it populates BOTH s3BucketInterface and s3Bucket.

If a construct accepts Bucket, then we expose just s3Bucket and always populate it.

biffgaut · 2022-01-04T21:38:21Z

source/patterns/@aws-solutions-constructs/aws-iot-s3/README.md

@@ -64,6 +64,7 @@ _Parameters_
 |loggingBucketProps?|[`s3.BucketProps`](https://docs.aws.amazon.com/cdk/api/latest/docs/@aws-cdk_aws-s3.BucketProps.html)|Optional user provided props to override the default props for the S3 Logging Bucket.|


If the construct accepts IBucket instead of bucket, then the name of the attribute needs to be existingBucketInterface (and only the s3BucketInterface property is populated)

biffgaut · 2022-01-04T21:46:11Z

source/patterns/@aws-solutions-constructs/aws-iot-s3/test/integ.iot-s3-defaultprops.ts

@@ -27,8 +27,12 @@ const props: IotToS3Props = {
      sql: "SELECT * FROM 'solutions/constructs'",
      actions: []
    }
+  },
+  logS3AccessLogs: false,


Just getting started on the review - at least one integ test has this turned on, right?

yes, we have a test case where this is turned on with access bucket destroyed during stack teardown

biffgaut · 2022-01-04T21:48:20Z

source/patterns/@aws-solutions-constructs/aws-iot-s3/test/integ.iot-s3-new-encrypted-bucket.ts

@@ -21,7 +21,8 @@ import { BucketEncryption } from "@aws-cdk/aws-s3";
 const app = new App();
 const stack = new Stack(app, generateIntegStackName(__filename));
 const existingKey = new kms.Key(stack, `existingKey`, {
-  enableKeyRotation: true
+  enableKeyRotation: true,
+  removalPolicy: RemovalPolicy.DESTROY
 });

 const props: IotToS3Props = {


This should have s3AccessLogs on, which is good - but we need to provide props for the logging bucket so that it gets cleaned up.

updated to clean up the access logs bucket

aws-solutions-constructs-team · 2022-01-05T07:14:44Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: f1cece2
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-solutions-constructs-team · 2022-01-05T07:15:19Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v1
Commit ID: f1cece2
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-solutions-constructs-team · 2022-01-05T10:12:58Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: b6891eb
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-solutions-constructs-team · 2022-01-05T10:13:29Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v1
Commit ID: b6891eb
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

…ns-constructs into aws-iot-s3

aws-solutions-constructs-team · 2022-01-05T19:28:02Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: 7cb5a2a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-solutions-constructs-team · 2022-01-05T19:28:26Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v1
Commit ID: 7cb5a2a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

biffgaut

A couple comment updates, 1 simplified line and one change in an integ test. These are all trivial - it looks good.

biffgaut · 2022-01-05T20:31:25Z

source/patterns/@aws-solutions-constructs/aws-iot-s3/README.md

+
+| **Name**     | **Type**        | **Description** |
+|:-------------|:----------------|-----------------|
+|s3Bucket?|[`s3.Bucket`](https://docs.aws.amazon.com/cdk/api/latest/docs/@aws-cdk_aws-s3.Bucket.html)|Returns an instance of the S3 bucket created by the pattern.|


Change to:

Returns an instance of the S3 bucket created by the pattern. If an existingBucketInterface is provided in IotToS3Props, then this value will be undefined.

biffgaut · 2022-01-05T20:31:28Z

source/patterns/@aws-solutions-constructs/aws-iot-s3/README.md

+| **Name**     | **Type**        | **Description** |
+|:-------------|:----------------|-----------------|
+|s3Bucket?|[`s3.Bucket`](https://docs.aws.amazon.com/cdk/api/latest/docs/@aws-cdk_aws-s3.Bucket.html)|Returns an instance of the S3 bucket created by the pattern.|
+|s3BucketInterface?|[`s3.IBucket`](https://docs.aws.amazon.com/cdk/api/latest/docs/@aws-cdk_aws-s3.IBucket.html)|Returns S3 Bucket interface created by the pattern.|


Change to:

Returns S3 Bucket interface created or used by the pattern. If an existingBucketInterface is provided in IotToS3Props, then only this value will be set and s3Bucket will be undefined. If the construct creates the bucket, then both properties will be set.

biffgaut · 2022-01-05T20:33:25Z

source/patterns/@aws-solutions-constructs/aws-iot-s3/lib/index.ts

+        loggingBucketProps: props.loggingBucketProps,
+        logS3AccessLogs: props.logS3AccessLogs
+      });
+      this.s3BucketInterface = s3.Bucket.fromBucketArn(this, `S3BucketInterface`, this.s3Bucket.bucketArn);


This line can just be:

this.s3BucketInterface = this.s3Bucket

source/patterns/@aws-solutions-constructs/aws-iot-s3/test/iot-s3.test.ts

aws-solutions-constructs-team · 2022-01-06T03:38:02Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: 80ccf45
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-solutions-constructs-team · 2022-01-06T03:38:32Z

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v1
Commit ID: 80ccf45
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

santhosh added 2 commits October 7, 2021 18:03

aws-iot-s3 construt implementation

1001ccc

Merge branch 'main' into aws-iot-s3

652ce0c

surukonda requested review from biffgaut, hayesry and hnishar as code owners October 25, 2021 15:19

surukonda and others added 3 commits October 25, 2021 20:58

Merge branch 'main' into aws-iot-s3

27fbc93

fix broken test

b96dc36

Merge branch 'aws-iot-s3' of https://github.com/surukonda/aws-solutio…

014e702

…ns-constructs into aws-iot-s3

santhosh and others added 2 commits October 25, 2021 16:58

fix cfn_nag issues

0201e70

Merge branch 'main' into aws-iot-s3

a307fd2

santhosh and others added 2 commits October 26, 2021 01:40

update KMS Key test

d1582b4

Merge branch 'main' into aws-iot-s3

e1ee7ec

biffgaut reviewed Oct 28, 2021

View reviewed changes

Merge branch 'main' into aws-iot-s3

f77ae3f

Merge branch 'awslabs:main' into aws-iot-s3

583471f

Merge branch 'main' into aws-iot-s3

fe3313a

santhosh added 2 commits January 3, 2022 17:56

update test cases & address pr review comments

7d336b5

Merge branch 'aws-iot-s3' of https://github.com/surukonda/aws-solutio…

5d8ac6a

…ns-constructs into aws-iot-s3

fix tests for cdk v2

995cf8f

biffgaut requested changes Jan 4, 2022

View reviewed changes

clean access logging buckets in integ tests

f1cece2

Merge branch 'main' into aws-iot-s3

b6891eb

santhosh added 2 commits January 5, 2022 19:20

Used IBucket instead of Bucket as existing bucket prop

0509670

Merge branch 'aws-iot-s3' of https://github.com/surukonda/aws-solutio…

7cb5a2a

…ns-constructs into aws-iot-s3

biffgaut requested changes Jan 5, 2022

View reviewed changes

address pr review comments

80ccf45

biffgaut approved these changes Jan 6, 2022

View reviewed changes

biffgaut merged commit ea024fc into awslabs:main Jan 6, 2022

		@@ -64,6 +64,7 @@ _Parameters_
		\|loggingBucketProps?\|[`s3.BucketProps`](https://docs.aws.amazon.com/cdk/api/latest/docs/@aws-cdk_aws-s3.BucketProps.html)\|Optional user provided props to override the default props for the S3 Logging Bucket.\|

feat(aws-iot-s3): new construct implementation #469

feat(aws-iot-s3): new construct implementation #469

Conversation

surukonda commented Oct 25, 2021

aws-solutions-constructs-team commented Oct 25, 2021

AWS CodeBuild CI Report

aws-solutions-constructs-team commented Oct 25, 2021

AWS CodeBuild CI Report

aws-solutions-constructs-team commented Oct 25, 2021

AWS CodeBuild CI Report

aws-solutions-constructs-team commented Oct 25, 2021

AWS CodeBuild CI Report

aws-solutions-constructs-team commented Oct 25, 2021

AWS CodeBuild CI Report

aws-solutions-constructs-team commented Oct 25, 2021

AWS CodeBuild CI Report

aws-solutions-constructs-team commented Oct 25, 2021

AWS CodeBuild CI Report

aws-solutions-constructs-team commented Oct 25, 2021

AWS CodeBuild CI Report

aws-solutions-constructs-team commented Oct 25, 2021

AWS CodeBuild CI Report

aws-solutions-constructs-team commented Oct 25, 2021

AWS CodeBuild CI Report

aws-solutions-constructs-team commented Oct 26, 2021

AWS CodeBuild CI Report

aws-solutions-constructs-team commented Oct 26, 2021

AWS CodeBuild CI Report

aws-solutions-constructs-team commented Oct 26, 2021

AWS CodeBuild CI Report

aws-solutions-constructs-team commented Oct 26, 2021

AWS CodeBuild CI Report

biffgaut left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

surukonda Oct 29, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aws-solutions-constructs-team commented Oct 29, 2021

AWS CodeBuild CI Report

aws-solutions-constructs-team commented Oct 29, 2021

AWS CodeBuild CI Report

aws-solutions-constructs-team commented Jan 3, 2022

AWS CodeBuild CI Report

aws-solutions-constructs-team commented Jan 3, 2022

AWS CodeBuild CI Report

aws-solutions-constructs-team commented Jan 3, 2022

AWS CodeBuild CI Report

aws-solutions-constructs-team commented Jan 3, 2022

AWS CodeBuild CI Report

aws-solutions-constructs-team commented Jan 3, 2022

AWS CodeBuild CI Report

aws-solutions-constructs-team commented Jan 3, 2022

AWS CodeBuild CI Report

aws-solutions-constructs-team commented Jan 4, 2022

AWS CodeBuild CI Report

aws-solutions-constructs-team commented Jan 4, 2022

AWS CodeBuild CI Report

biffgaut left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aws-solutions-constructs-team commented Jan 5, 2022

AWS CodeBuild CI Report

aws-solutions-constructs-team commented Jan 5, 2022

AWS CodeBuild CI Report

surukonda Oct 29, 2021 •

edited

Loading