feat(new construct): aws-fargate-kinesisfirehose #881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
biffgaut
requested review from
hayesry,
mobri2a,
emcfins,
mickychetta and
georgebearden
as code owners
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
georgebearden
previously approved these changes
Dec 22, 2022
|
|
||
| // The construct requires an existing Firehose Delivery Stream, this can be created in raw CDK or extracted | ||
| // from a previously instantiated construct that created an Firehose Delivery Stream | ||
| const existingFirehoseDeliveryStream = previoslyCreatedKinesisFirehoseToS3Construct.kinesisFirehose; |
There was a problem hiding this comment.
Nit typo - previosly -> previously
There was a problem hiding this comment.
Same nit in the other code samples
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
biffgaut
commented
Dec 27, 2022
source/patterns/@aws-solutions-constructs/aws-fargate-kinesisfirehose/lib/index.ts
Outdated
Show resolved
Hide resolved
source/patterns/@aws-solutions-constructs/aws-fargate-kinesisfirehose/lib/index.ts
Outdated
Show resolved
Hide resolved
source/patterns/@aws-solutions-constructs/aws-fargate-kinesisfirehose/lib/index.ts
Outdated
Show resolved
Hide resolved
source/patterns/@aws-solutions-constructs/aws-fargate-kinesisfirehose/lib/index.ts
Show resolved
Hide resolved
source/patterns/@aws-solutions-constructs/aws-fargate-kinesisfirehose/lib/index.ts
Outdated
Show resolved
Hide resolved
...ws-solutions-constructs/aws-fargate-kinesisfirehose/test/aws-fargate-kinesisfirehose.test.ts
Outdated
Show resolved
Hide resolved
...ws-solutions-constructs/aws-fargate-kinesisfirehose/test/aws-fargate-kinesisfirehose.test.ts
Outdated
Show resolved
Hide resolved
...ws-solutions-constructs/aws-fargate-kinesisfirehose/test/aws-fargate-kinesisfirehose.test.ts
Outdated
Show resolved
Hide resolved
source/patterns/@aws-solutions-constructs/aws-fargate-kinesisfirehose/test/integ.noArguments.ts
Outdated
Show resolved
Hide resolved
source/patterns/@aws-solutions-constructs/aws-lambda-kinesisfirehose/README.md
Show resolved
Hide resolved
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
georgebearden
requested changes
Dec 28, 2022
|
|
||
| # The construct requires an existing Firehose Delivery Stream, this can be created in raw CDK or extracted | ||
| # from a previously instantiated construct that created an Firehose Delivery Stream | ||
| const existingFirehoseDeliveryStream = previouslyCreatedKinesisFirehoseToS3Construct.kinesisFirehose; |
There was a problem hiding this comment.
remove the const here
|
|
||
| // The construct requires an existing Firehose Delivery Stream, this can be created in raw CDK or extracted | ||
| // from a previously instantiated construct that created an Firehose Delivery Stream | ||
| const existingFirehoseDeliveryStream = previouslyCreatedKinesisFirehoseToS3Construct.kinesisFirehose; |
There was a problem hiding this comment.
remove the const here
| */ | ||
| readonly existingFargateServiceObject?: ecs.FargateService; | ||
| /** | ||
| * An existing Kinesis Firehose Delivery Stream to which the Lambda function can put data. Note - the delivery stream |
There was a problem hiding this comment.
Nit - change Lambda function to Fargate Service
| * a container from a public repo, this must be true so the repo can be accessed from the | ||
| * network. | ||
| * | ||
| * @default - none |
There was a problem hiding this comment.
Nit based on the last fargate-kinesisstreams PR - remove the @default - none since this ins't an optional property.
| @@ -0,0 +1,94 @@ | |||
| { | |||
| "name": "@aws-solutions-constructs/aws-fargate-kinesisfirehose", | |||
| "version": "2.29.0", | |||
There was a problem hiding this comment.
In this file, there are many explicit version numbers here and din the dependency sections below. Most of these should be set to 0.0.0, like here, correct?
| @@ -48,7 +53,12 @@ from aws_cdk import ( | |||
| ) | |||
| from constructs import Construct | |||
|
|
|||
| # The construct requires an existing Firehose Delivery Stream, this can be created in raw CDK or extracted | |||
| # from a previously instantiated construct that created an Firehose Delivery Stream | |||
| const existingFirehoseDeliveryStream = previouslyCreatedKinesisFirehoseToS3Construct.kinesisFirehose; | |||
| @@ -67,7 +77,12 @@ import software.amazon.awscdk.services.lambda.*; | |||
| import software.amazon.awscdk.services.lambda.Runtime; | |||
| import software.amazon.awsconstructs.services.lambdakinesisfirehose.*; | |||
|
|
|||
| // The construct requires an existing Firehose Delivery Stream, this can be created in raw CDK or extracted | |||
| // from a previously instantiated construct that created an Firehose Delivery Stream | |||
| const existingFirehoseDeliveryStream = previouslyCreatedKinesisFirehoseToS3Construct.kinesisFirehose; | |||
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes Issue #880
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.