Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is the authorization endpoint /authorize and not /oauth2/authorize ? #77

Open
tksx1227 opened this issue Sep 7, 2023 · 0 comments

Comments

@tksx1227
Copy link

tksx1227 commented Sep 7, 2023

How can we help?

Firstly, I'd like to express my gratitude for developing such a useful project!

While perusing the source code, I noticed that this project uses the endpoint https://${this._userPoolDomain}/authorize for Cognito's authorization endpoint. Yet, the official Cognito documentation lists the authorization endpoint as /oauth2/authorize .

const userPoolUrl = `https://${this._userPoolDomain}/authorize?redirect_uri=${oauthRedirectUri}&response_type=code&client_id=${this._userPoolAppId}&state=${state}`;

https://docs.aws.amazon.com/cognito/latest/developerguide/authorization-endpoint.html#get-authorize

Could you shed light on the choice to use /authorize instead of /oauth2/authorize ? While everything seems to be functioning correctly as is, aligning with the official documentation might be beneficial for clarity and potential future-proofing.

If there were specific considerations or historical reasons for this choice during the early implementation phases, I'd be keen to understand.

Should you consider making this adjustment, I'm more than willing to submit a PR and would be glad to have it reviewed at your convenience :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant