Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Upbound Provider EKS composition #164

Open
tomikonio opened this issue Jan 26, 2024 · 5 comments
Open

[FEATURE] Upbound Provider EKS composition #164

tomikonio opened this issue Jan 26, 2024 · 5 comments

Comments

@tomikonio
Copy link

Is your feature request related to a problem? Please describe

There is no EKS composition for the upbound AWS provider, only for the contrib one

Describe the solution you'd like

Create an EKS composition for the upbound provider

Describe alternatives you've considered

Each of us can create our own composition, but it would be beneficial for us all to have an "official" one that adheres to AWS best practices and will be actively maintained

@ytsarev
Copy link
Contributor

ytsarev commented Jan 27, 2024

@tomikonio
Copy link
Author

tomikonio commented Jan 28, 2024

@ytsarev Thanks.
Sadly it is not a ready solution as of now - there are some lacking resources in the Xnetwork configuration - i.e. private subnets using a route table that is used for the public ones (0.0.0.0/0 -> igw), no natgw.

@ytsarev
Copy link
Contributor

ytsarev commented Jan 28, 2024

Totally, that's why we name it as basic Composition in https://github.com/upbound/configuration-aws-network and leave room for more complex XNetwork implementation depending on specific infrastructure needs.

@shay-berman
Copy link

@ytsarev few questions:

  1. is there any upbound hub for shared compositions?
  2. about terminology, why all the component usually set name with X at the beginning? any guideline for name conversion? what X stand for?
  3. Setting up EKS composition, would you recommend to add inside the composition also the create of the relevant roles? of roles better to be define in different composition? (because sometime a company allow admin persona to create the cluster and vpn but other person to configure the permissions. Do you have 2 cent on that?
  4. Is there any composition linter tool?

@ytsarev
Copy link
Contributor

ytsarev commented Jan 31, 2024

Hey @shay-berman , great questions :)

  1. Yes, we publish Crossplane Configurations to https://marketplace.upbound.io/ and it would be great to see crossplane-on-eks Configurations there btw :)
  2. X stands for Composite Resource, meaning that it is cluster-scoped in contrast to namespace-scoped Claim that is usually named without X, like XDatabase(XR) vs Database(Claim), for end-user consumption. It is a soft naming convention and not enforced by the code.
  3. It depends on your organization's requirements, if you need to create a separate abstraction for role management, I would definitely create a separate XR/Composition for it.
  4. crossplane validate is coming in the next release Offline Schema Validation for Crossplane resources crossplane/crossplane#5162

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In progress
Development

No branches or pull requests

3 participants