Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build script on other platforms #139

Closed
wants to merge 1 commit into from

Conversation

ganey
Copy link

@ganey ganey commented Jul 30, 2019

Description of changes:
By updating the npm install section of the build script to force the linux binaries for the AMI, the solution can then also be built/deployed from a mac.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

By updating the `npm install` section of the build script to force the linux binaries for the AMI, the solution can then also be built/deployed from a mac.
@blaineo
Copy link

blaineo commented Aug 1, 2019

Gah, this would have saved me a couple hours... Hope this gets in soon.

@hayesry
Copy link
Member

hayesry commented Aug 3, 2019

@ganey Thanks for submitting this pull request. I've merged your commits into our next minor version branch and hope to have it published shortly!

@rromanchuk
Copy link

Looks like something is still getting tripped up in the function, has anyone been able to build current HEAD on a darwin machine? Might just be an issue with my deploy.

Something went wrong installing the "sharp" module

Module did not self-register.

@ganey
Copy link
Author

ganey commented Dec 24, 2019

I haven't tried building this recently as I use a fork, I do know it doesn't build for node12 though as it can't find the correct sharp binary

@beomseoklee
Copy link
Member

Thanks for your effort here, @ganey
We have updated our solution, and your pull request has been merged into our master branch. However, as we've merged many pull requests at this time, the source code might not exactly same as what you've done. In addition, due to our internal process, we've merged source code manually, so please understand how your effort has been merged.

You can refer to the recent changes here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants