Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SimilarityModel3D and RigidModel3D only fit rotations, not reflections #47

Open
aschampion opened this issue Feb 19, 2019 · 0 comments
Open

Comments

@aschampion
Copy link

Title says it all, with more discussion here: catmaid/CATMAID#1857

My questions:

  1. I'd be happy to fix and PR this here, also, but not knowing how/where this library is used, the proper rotation restriction may be preferred. Should I bother with a PR?
  2. If "yes" to 1: There's a lot of functionally identical but slightly syntactically varying code duplicated between AffineModel3D/SimilarityModel3D/RigidModel3D. It'd be easier for me to clean some of this up as part of a PR, but your preference may be for minimal change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant