Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Characters are not marked as offline in characters.online #20545

Closed
d-christ opened this issue Nov 13, 2024 · 3 comments
Closed

Characters are not marked as offline in characters.online #20545

d-christ opened this issue Nov 13, 2024 · 3 comments

Comments

@d-christ
Copy link

Current Behaviour

When a character loggs in and then logs out it is still marked as online in the "characters" table (online is on 1). Its only reset when the server is restarted.

Expected Blizzlike Behaviour

Characters who log off should be offline.

Source

No response

Steps to reproduce the problem

  1. Log in
  2. Log out
  3. Check characters table for that character, value vor "online" is 1, not 0.

Extra Notes

No response

AC rev. hash/commit

AC> AzerothCore rev. unknown 1970-01-01 00:00:00 +0000 (Archived branch) (Unix, Release, Static)
Connected players: 0. Characters in world: 1369.
Connection peak: 1.
Server uptime: 12 hour(s) 47 minute(s) 45 second(s)
Update time diff: 10ms. Last 500 diffs summary:
|- Mean: 13ms
|- Median: 11ms
|- Percentiles (95, 99, max): 26ms, 30ms, 32ms
Using SSL version: OpenSSL 3.0.2 15 Mar 2022 (library: OpenSSL 3.0.2 15 Mar 2022)
Using Boost version: 1.74.0
Using CMake version: 3.22.1
Using MySQL version: 80040
Found MySQL Executable: /usr/bin/mysql
Compiled on: Linux 5.15.0-125-generic
Worldserver listening connections on port %u
Realmlist (Realm Id: 1) configured in port 8085
VMAPs status: Enabled. LineOfSight: true, getHeight: true, indoorCheck: true
MMAPs status: Enabled
maps directory located in /home/azerothcore/azerothcore-wotlk/data/maps. Total size: 291014951 bytes
vmaps directory located in /home/azerothcore/azerothcore-wotlk/data/vmaps. Total size: 658130721 bytes
mmaps directory located in /home/azerothcore/azerothcore-wotlk/data/mmaps. Total size: 2192910844 bytes
Default DBC locale: enUS.
All available DBC locales: enUS
Using World DB: ACDB 335.12-dev
Using Playerbots DB Revision:
Latest LoginDatabase update: 2024_01_20_00.sql
Latest CharacterDatabase update: playerbots_names.sql
Latest WorldDatabase update: world_playerbots_rpg_races.sql
LoginDatabase queue size: 0
CharacterDatabase queue size: 0
WorldDatabase queue size: 0
PlayerbotsDatabase queue size: 0
List of enabled modules:
|- mod-ah-bot
|- mod-aoe-loot
|- mod-breaking-news-override
|- mod-eluna
|- mod-guildhouse
|- mod-playerbots
|- mod-transmog

Operating system

Ubuntu 22

Custom changes or Modules

Eluna (not used, just installed, AH-Bot, AOE-loot (no changes), guildhouse, playerbots (1000 Bots), transmog, breaking news.

Except for the more playerbots all plugins are just installed and are used "as is".

@TheSCREWEDSoftware
Copy link
Contributor

TheSCREWEDSoftware commented Nov 13, 2024

Can't replicate this issue, fix your harsh and report this issue to PlayerBots github.

@noisiver
Copy link
Contributor

noisiver commented Nov 13, 2024

This is not specific to playerbots. It happens without it, it always has. If you look through the code you will find that characters are only marked as offline (online = 0) on server startup. NEVER when they actually log out. There is a reason why there's a draft PR addressing this issue here.

@noisiver
Copy link
Contributor

I tried to replicate it but can't anymore. I know it was an issue before but it no longer is in stock AC. I tested every situation I could think of and it always gets set to 0. They were correct in dismissing this and closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants