Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in technical profile sample - jit-migration-v2 #37

Open
bzuillsmith opened this issue Oct 1, 2022 · 0 comments
Open

Bug in technical profile sample - jit-migration-v2 #37

bzuillsmith opened this issue Oct 1, 2022 · 0 comments

Comments

@bzuillsmith
Copy link

bzuillsmith commented Oct 1, 2022

I think this technical profile validation step is missing a precondition. It should not run the REST call if the user is already found in AzureAD. We only want to know if it is in the legacy DB when it's not found in Azure AD.

Probably something like

          <Preconditions>
            <Precondition Type="ClaimsExist" ExecuteActionsIf="true">
              <Value>objectId</Value>
              <Action>SkipThisValidationTechnicalProfile</Action>
            </Precondition>
          </Preconditions>

Just wanted to post this issue rather than make a pull request because I'm still fairly new to all this and don't want to presume I'm right

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant