Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

B2C extension notready for tenant.partner.onmschina.cn #85

Open
thomastrinamix opened this issue Apr 7, 2022 · 0 comments · May be fixed by #87
Open

B2C extension notready for tenant.partner.onmschina.cn #85

thomastrinamix opened this issue Apr 7, 2022 · 0 comments · May be fixed by #87

Comments

@thomastrinamix
Copy link

We like your B2C extension.
However, we realized it is not compatible with azure AD B2C China: tenant.partner.onmschina.cn

MSGraphTokenHelper.ts

vscode-extension/src/services/MSGraphTokenHelper.ts

Line 13 in 9e5606d

tenantId = tenantId.toLowerCase().replace(Consts.SamplesYourTenant, MSGraphTokenHelper.getMSGraphDefaultTenantID() + ".onmicrosoft.com")

PolicyUpload.ts

vscode-extension/src/PolicyUpload.ts

Line 246 in 9e5606d

docContent = docContent.replace(new RegExp("\yourtenant.onmicrosoft.com", "gi"), MSGraphTokenHelper.getMSGraphDefaultTenantID() + ".onmicrosoft.com");

@thomastrinamix thomastrinamix linked a pull request Apr 22, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/globalize b2c extension thomastrinamix/vscode-extension
1 participant
@thomastrinamix