Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ValCommissionChangeLimitDecorator #41

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

zsystm
Copy link

@zsystm zsystm commented Aug 23, 2023

Description

  • Closes feat: handle validator fee rate change #37
  • ValCommissionChangeLimitDecorator limits MsgEditValidator which change commission rates.
    • msg only can be accepted within 23 hours and 50 minutes of next epoch time.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • included the necessary unit and integration tests
  • reviewed "Files changed" and left comments if necessary

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@zsystm zsystm self-assigned this Aug 23, 2023
@zsystm zsystm requested a review from dongsam August 23, 2023 03:31
@zsystm zsystm marked this pull request as ready for review August 23, 2023 03:57
Copy link
Member

@dongsam dongsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but ParamChangeLimitDecorator and ValCommissionChangeLimitDecorator are all the same logic except for switch case branch logic, so it seems that they can be refactored into one decorator and processed as a switch case without having to iterate authz msgs in duplicate. First of all, the schedule is limited, so let's leave it as an issue and proceed later

@zsystm zsystm merged commit b788533 into liquidstaking-module Aug 23, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: handle validator fee rate change
2 participants