Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only use 1d rope? #30

Open
junwuzhang19 opened this issue Oct 21, 2024 · 1 comment
Open

only use 1d rope? #30

junwuzhang19 opened this issue Oct 21, 2024 · 1 comment

Comments

@junwuzhang19
Copy link

Hi, thanks for your great work!

I read the code and found emu3 only use 1d rope for both visual and language content. I wonder if 1d rope will bring some problems to image and video generation results.

Thanks!

@Wolfwjs
Copy link

Wolfwjs commented Oct 22, 2024

Hi, thanks for your interest!

We chose to use 1d rope for simplicity, and it works well. However, exploring higher-dimensional RoPEs (like 2d or 3d) is definitely worth trying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants