Include decorator and class field plugins after TypeScript, if p… (#311)

Include decorator and class field plugins after TypeScript, if present
emberjs · Dec 12, 2019 · 0d4dcc3 · 0d4dcc3
2 parents bc0dee4 + e08b59d
commit 0d4dcc3
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/index.js b/index.js
@@ -340,7 +340,8 @@ module.exports = {
         plugins,
         [require.resolve('@babel/plugin-proposal-decorators'), { legacy: true }],
         {
-          before: ['@babel/plugin-proposal-class-properties', '@babel/plugin-transform-typescript']
+          before: ['@babel/plugin-proposal-class-properties'],
+          after: ['@babel/plugin-transform-typescript']
         }
       );
     }
@@ -357,8 +358,7 @@ module.exports = {
         plugins,
         [require.resolve('@babel/plugin-proposal-class-properties'), { loose: options.loose || false }],
         {
-          after: ['@babel/plugin-proposal-decorators'],
-          before: ['@babel/plugin-transform-typescript']
+          after: ['@babel/plugin-proposal-decorators', '@babel/plugin-transform-typescript']
         }
       );
     }

diff --git a/node-tests/addon-test.js b/node-tests/addon-test.js
@@ -792,6 +792,12 @@ describe('ember-cli-babel', function() {
 
       expect(loosePlugins[1][1].loose).to.equal(true, 'loose setting added correctly');
     });
+
+    it('should include class fields and decorators after typescript if detected', function() {
+      let plugins = this.addon._addDecoratorPlugins(['@babel/plugin-transform-typescript'], {});
+      expect(plugins[0]).to.equal('@babel/plugin-transform-typescript', 'typescript still first');
+      expect(plugins.length).to.equal(3, 'class fields and decorators added');
+    });
   });
 
   describe('_shouldIncludeHelpers()', function() {