Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for showing disconnected devices / Removing stale devices #7

Closed
tgurr opened this issue Sep 17, 2020 · 5 comments
Closed

Support for showing disconnected devices / Removing stale devices #7

tgurr opened this issue Sep 17, 2020 · 5 comments
Labels
feature request next release fixed in develop branch and will be part of the next release

Comments

@tgurr
Copy link

tgurr commented Sep 17, 2020

When making use of the Play button of the Snapweb web client a new client is created and they may end up piling up when using different browsers/devices/sessions so it would be great to be able to add a toggle to display disconnected devices and also have the ability to remove them because having to edit the server.json manually to get rid of them is quite cumbersome.

@badaix
Copy link
Owner

badaix commented Sep 23, 2020

I would like to have a menu for this, similar to the one in Snapdroid, a button with three dots or a hamburger button that opens a context menu with an "about..." option and a "[x] show hidden clients" checkbox.
It's not there yet, because I'm by far not an expert in web development (this is my first web project), and without using a framework (not needed so far, will keep the site small), it's quite some fiddly task.
What you can do is replacing in line 278 of snapcontrol.js

let hide_offline = true;

with

let hide_offline = false;

It should also show a button to remove the clients for each offline client

@badaix badaix added feature request good first issue Good for newcomers help wanted Extra attention is needed labels Sep 23, 2020
@radusuciu
Copy link

@badaix Seems like you're potentially interested in accepting PRs? If so, a few questions:

  • are you interested in refactoring PRs?
  • do you have any browser support goals - eg. IE11?

@badaix
Copy link
Owner

badaix commented Sep 26, 2020

Of course, I'm accepting PRs. General design goals are to keep it small and simple and to run on relevant browsers, including iOS.

@novwhisky
Copy link

@badaix Are you against using any framework in this project? I see #32 proposed Vue, albeit with lots of extra changes. Something modern but lightweight could be beneficial having reviewed the source.

@badaix badaix added next release fixed in develop branch and will be part of the next release and removed help wanted Extra attention is needed good first issue Good for newcomers labels Sep 25, 2023
@badaix
Copy link
Owner

badaix commented Mar 7, 2024

Fixed in v0.6.0

@badaix badaix closed this as completed Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request next release fixed in develop branch and will be part of the next release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants