externalDelegatedBalance discrepancy with delegator list

[nicolasochem]

Hi,

I am having a baker fail a TRD invariant.

Specifically, the sum of delegatedBalance for all delegators does not match externalDelegatedBalance.

You can see for yourself with jq:

$ curl -s 'https://api.tzkt.io/v1/rewards/split/tz1MbhmEwEAzzfb3naSr7vTp4mDxB8HsknA9/760?offset=0&limit=10000' | jq '         
{
  externalDelegatedBalance: .externalDelegatedBalance,
  sumOfAllDelegatorBalances: ( .delegators | map(.delegatedBalance) | add )
}
' 
{
  "externalDelegatedBalance": 134799604249,
  "sumOfAllDelegatorBalances": 134791833489
}

This started happening during cycle 760. Cycle 759 and prior were fine:

$ curl -s 'https://api.tzkt.io/v1/rewards/split/tz1MbhmEwEAzzfb3naSr7vTp4mDxB8HsknA9/759?offset=0&limit=10000' | jq '
{
  externalDelegatedBalance: .externalDelegatedBalance,
  sumOfAllDelegatorBalances: ( .delegators | map(.delegatedBalance) | add )
}
' 
{
  "externalDelegatedBalance": 134632713172,
  "sumOfAllDelegatorBalances": 134632713172
}

[nicolasochem]

Since there is a discrepancy of 8 tez, I am inclined to think it's about this delegator which has a finalizable balance with this baker.

[nicolasochem]

So it looks like in order to reconcile these 2 values I have to query the following:

$ curl 'https://api.tzkt.io/v1/staking/unstake_requests?baker=tz1MbhmEwEAzzfb3naSr7vTp4mDxB8HsknA9&status-=finaliz
able'  | jq

And then filter out the baker's own finalizable amounts.

The remaining entries are pending finalize unstake, for which the delegation rewards accrue and should be paid. Could you please confirm?

[Groxan]

That's a bug :(

The account tz1QM7QAKgjuZvSVqTU4VYfmvWbAxBBFQRka with unstaked balance 7770760 didn't get into snapshot and therefore was missed in the delegators list in the rewards split.

The bug happened because the account cancelled delegation and the SQL query WHERE account."UnstakedBakerId" != account."DelegateId" was broken, because in Postgres not_null != null returns null instead of true.

Thank you very much for spotting! We will fix it ASAP.