-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add best practices for dealing with localisation #24
Comments
I mentioned not using a wrapper for |
What do you have in mind? |
I like the JSON approach https://github.com/tomkowz/Swifternalization |
This seems interesting. Will take a closer look tomorrow if time allows. 👍 |
This was suggested as well. import Foundation
extension String {
func localized() -> String {
return self.localizedWithComment("")
}
func localizedWithComment(comment:String) -> String {
return NSLocalizedString(self, tableName: nil, bundle: NSBundle.mainBundle(), value: "", comment: comment)
}
} |
So far I would go for having a tool that would generate static keys for every key in a localization file. |
I'd like that. No issues with typos. |
|
This is addressed in the updated style guide in #118 |
Needs some research as well, on possible methods to deal with it. NSLocalizedString() is subpar.
The text was updated successfully, but these errors were encountered: