Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Managed tokens added/removed #545

Open
mendesfabio opened this issue Dec 11, 2023 · 0 comments
Open

fix Managed tokens added/removed #545

mendesfabio opened this issue Dec 11, 2023 · 0 comments
Assignees

Comments

@mendesfabio
Copy link
Member

mendesfabio commented Dec 11, 2023

After working on #538 I realized I missed to handle tokens added/removed. It's not critical for now as pools from Kassandra are only going to change weights (not add/remove tokens) but still something we should fix. There's this example query showing a pool that had its tokens composition changed and, because of that, some tokens don't have weight (see nulls).

We have to analyze this pool's events, ensure everything is being handled (also see if the order they're emitted makes sense), and finally call updatePoolWeights from either (or all, needs investigation) events handlers:

  • handleTokenAdded
  • handleTokenRemoved
  • handleGradualWeightUpdateScheduled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants