Add function to revoke permit on BPT #1009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jubeira
approved these changes
Oct 4, 2024
There was a problem hiding this comment.
LGTM! The fix is correct; I'd be a bit more specific with the comments, otherwise it gives the impression that it can revoke permits that were executed already which is not the case.
Thanks @EndymionJkb !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Per ToB issue:
"The BalancerPoolToken contract implements the permit function, allowing users to sign a payload in order to allow another user or contract to spend their tokens. However, once a user signs a payload and sends it to another user, they have no way of revoking this signature. Since only one nonce is valid until it is consumed, this would prevent the original user from submitting permit signatures with a different nonce."
This adds a
revokePermitfunction that increments the nonce.Type of change
Checklist:
main, or there's a description of how to mergeIssue Resolution
Resolves #1007