Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make remaining Router operations payable #1011

Open
EndymionJkb opened this issue Sep 25, 2024 · 0 comments · May be fixed by #1012
Open

Make remaining Router operations payable #1011

EndymionJkb opened this issue Sep 25, 2024 · 0 comments · May be fixed by #1012
Assignees
@EndymionJkb

Comments

@EndymionJkb
Copy link
Collaborator

Per TOB-BALV3-18, while permitBatchAndCall is payable, not all Router operations are payable, and mixing payable and non-payable operations will revert. For instance, an "add liquidity" operation followed by a "remove custom liquidity" would currently fail. Recovery mode would also revert in a batch, if combined with other payable operations.
@EndymionJkb EndymionJkb self-assigned this Sep 25, 2024
@EndymionJkb EndymionJkb linked a pull request Sep 25, 2024 that will close this issue
Open
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EndymionJkb EndymionJkb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Payable Router operations balancer/balancer-v3-monorepo
1 participant
@EndymionJkb