Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permit error handling #1024

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Permit error handling #1024

wants to merge 4 commits into from

Conversation

EndymionJkb
Copy link
Collaborator

Description

Protect calls to permit against front-running by catching failures and not reverting the transaction if the signature was consumed but nothing else nefarious happened.

Unfortunately this adds a fair bit of bytecode, and makes CompositeLiquidityRouter go over the limit (at least with its current non-viaIR compilation).

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Dependency changes
  • Code refactor / cleanup
  • Optimization: [ ] gas / [ ] bytecode
  • Documentation or wording changes
  • Other

Checklist:

  • The diff is legible and has no extraneous changes
  • Complex code has been commented, including external interfaces
  • Tests have 100% code coverage
  • The base branch is either main, or there's a description of how to merge

Issue Resolution

Resolves #1023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error handling in permitBatchAndCall
1 participant