Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test rounding scenarios in Base Math, Weighted Math and Stable Math #505

Open
joaobrunoah opened this issue Apr 16, 2024 · 1 comment · Fixed by #526
Open

Test rounding scenarios in Base Math, Weighted Math and Stable Math #505

joaobrunoah opened this issue Apr 16, 2024 · 1 comment · Fixed by #526
Assignees
@0xJabberwock
Milestone
Testing

Comments

@joaobrunoah
Copy link
Contributor

PRs #468 #488 #489 fixed rounding issues we had in pool maths. We should test these changes to make sure the code is maintainable (which means, the code survives the time).
This was referenced Apr 16, 2024
Merged
Merged
@0xJabberwock 0xJabberwock self-assigned this Apr 17, 2024
@0xJabberwock 0xJabberwock added this to the Testing milestone Apr 24, 2024
@0xJabberwock
Copy link
Contributor

0xJabberwock commented Apr 24, 2024 •
edited
Loading

@0xJabberwock 0xJabberwock linked a pull request Apr 24, 2024 that will close this issue
test: StableMath rounding #526
Merged
11 tasks
@0xJabberwock 0xJabberwock removed a link to a pull request Apr 24, 2024
test: StableMath rounding #526
Merged
11 tasks
@0xJabberwock 0xJabberwock linked a pull request Jun 5, 2024 that will close this issue
test: StableMath rounding #526
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0xJabberwock 0xJabberwock

Labels
None yet
Projects
None yet
Milestone
Testing
Development

Successfully merging a pull request may close this issue.

test: StableMath rounding balancer/balancer-v3-monorepo
2 participants
@joaobrunoah @0xJabberwock